From 2e9869028ab80f13da79517d4572b5d6044ac228 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 9 Jan 2015 17:30:32 +0100 Subject: [PATCH] spinlock: use local_irq_disable() instead of local_irq_save() where possible ... as generally being a cheaper operation. Signed-off-by: Jan Beulich Reviewed-by: Tim Deegan Reviewed-by: Andrew Cooper --- xen/common/spinlock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/common/spinlock.c b/xen/common/spinlock.c index f9f19a88cb..13340a3f61 100644 --- a/xen/common/spinlock.c +++ b/xen/common/spinlock.c @@ -162,7 +162,7 @@ unsigned long _spin_lock_irqsave(spinlock_t *lock) local_irq_restore(flags); while ( likely(_raw_spin_is_locked(&lock->raw)) ) cpu_relax(); - local_irq_save(flags); + local_irq_disable(); } LOCK_PROFILE_GOT; preempt_disable(); @@ -313,7 +313,7 @@ unsigned long _read_lock_irqsave(rwlock_t *lock) local_irq_restore(flags); while ( (x = lock->lock) & RW_WRITE_FLAG ) cpu_relax(); - local_irq_save(flags); + local_irq_disable(); } } while ( cmpxchg(&lock->lock, x, x+1) != x ); preempt_disable(); @@ -409,7 +409,7 @@ unsigned long _write_lock_irqsave(rwlock_t *lock) local_irq_restore(flags); while ( (x = lock->lock) & RW_WRITE_FLAG ) cpu_relax(); - local_irq_save(flags); + local_irq_disable(); } } while ( cmpxchg(&lock->lock, x, x|RW_WRITE_FLAG) != x ); while ( x != 0 ) -- 2.30.2